fix(export): Escape MySQL column names #8961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andres-lowrie
requested review from
mangalaman93,
meghalims,
sanjayk-github-dev,
harshil-goel,
all-seeing-code,
billprovince and
joshua-goldstein
as code owners
MichelDiz
approved these changes
Aug 18, 2023
mangalaman93
approved these changes
Aug 18, 2023
|
Thank you for the PR @andres-lowrie |
jbhamra1
pushed a commit
that referenced
this pull request
Aug 18, 2023
This change wraps all the column names with backticks so that MySQL won't complain when a table has columns that are also reserved keywords in MySQL.
shivaji-dgraph
pushed a commit
that referenced
this pull request
Mar 12, 2024
This change wraps all the column names with backticks so that MySQL won't complain when a table has columns that are also reserved keywords in MySQL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This change wraps all the column names with backticks so that MySQL won't complain when a table has columns that are also reserved keywords in MySQL.