Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add validation for directive arguments inside Type Definition #4

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

minhaj-shakeel
Copy link

Fixes GRAPHQL-671.

This PR adds argument validation in the directive validation applied to the fields inside a given type.
For example earlier

type T { 
  dummyField: String! @search(xyz: [hash])
}

didn't return error while validation of type but now it does.

harshil and others added 9 commits December 11, 2019 13:50
@StevenACoffman
Copy link

@minhaj-shakeel Hi! I've started maintaining vektah/gqlparser and I would love to merge your improvements upstream. I know you are all dealing with quite a bit, but if I can help in any way, please don't hesitate to let me know.

@StevenACoffman
Copy link

Hello again! I would love to help merge the improvements in this fork into the upstream version. I would really appreciate it if you can open PRs there if you get a chance. I made a draft mega-giant-one just to remember what all the DGraph changes were: vektah#179

People who contributed to that are:
@pawanrawal @JatinDev543 @harshil-goel @anurags92 @NamanJain8

@CLAassistant
Copy link

CLAassistant commented Apr 29, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

✅ harshil-goel
❌ minhaj-shakeel
❌ ahsanbarkati
You have signed the CLA already but the status is still pending? Let us recheck it.

@cscetbon
Copy link

hey, is that PR dead ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants