Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate DGraph fork changes #179

Draft
wants to merge 38 commits into
base: master
Choose a base branch
from
Draft

Integrate DGraph fork changes #179

wants to merge 38 commits into from

Conversation

StevenACoffman
Copy link
Collaborator

@StevenACoffman StevenACoffman commented Feb 1, 2022

I would like to integrate the DGraph fork changes, but I would prefer to do them individually, unfortunately both forks have diverged. Help wanted! Especially from the original authors like @pawanrawal @JatinDev543 @harshil-goel @anurags92 @NamanJain8

pawanrawal and others added 30 commits November 3, 2020 12:52
Sync changes with upstream
Fixes GRAPHQL-789
This PR allows coercing of single values in variables to list.
fix(GraphQL): This PR change the coerced slice to type interface.
The following query was giving panic because here we passed ID as an int which is expected to be a string.

query allStories {
      queryUser(filter: {
        id: 22
      }) {
        stories {
          id
          text
        }
      }
    }

We now added input coercion so that the ID type value will be coerced to string type. And if we give a slice of integer values or the required type is [ID] then that will be coerced to slice of integer values.
fix(GraphQL): Fix bug that got introduced in last commit , which doesn't allow string value in [ID] to be coerced to list.
Fixes GRAPHQL-1006
In this PR we have added input coercion for Integers which are passed in variables.
Previously this code was part of dgraph.
Fixes: GRAPHQL-1007
We have allowed to paas @cascade arguments through variables in dgraph. For that we needed input validations check which is added in this library.
fix(GraphQL): fix validation when we give non-string value in variable and expected type is string.
fix(GraphQL): fix error while validation when we give Int or Float to String.
fix(GRAPHQL): Remove support of String --> int32 coercion in variables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants