fix(offline-interface): prevent infinite update loop in Chrome #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mediremi
approved these changes
Sep 7, 2021
dhis2-bot
added a commit
that referenced
this pull request
Sep 7, 2021
## [7.6.3](v7.6.2...v7.6.3) (2021-09-07) ### Bug Fixes * **offline-interface:** prevent infinite update loop in Chrome ([#638](#638)) ([079f6ea](079f6ea))
|
🎉 This PR is included in version 7.6.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
dhis2-bot
added a commit
that referenced
this pull request
Sep 8, 2021
# [8.0.0-beta.4](v8.0.0-beta.3...v8.0.0-beta.4) (2021-09-08) ### Bug Fixes * **dependencies:** update app-runtime to v3 ([8777699](8777699)) * **offline-interface:** prevent infinite update loop in Chrome ([#638](#638)) ([079f6ea](079f6ea)) * **recording-mode:** handle fulfilled requests after recording error ([#642](#642)) ([928e2cb](928e2cb)) * import index.css in index.js so styles are applied ([8db1bf8](8db1bf8)) * **shell:** create new stacking context for roots ([324a095](324a095)) * catch errors in completeRecording ([e67ae82](e67ae82)) * check whole URL against filter patterns ([5468114](5468114)) * only return sections with cached data from getCachedSections ([f6242d1](f6242d1)) * reopen indexedDB if global state resets ([0aded68](0aded68)) * return true if either cache or idb entry is removed ([43d8001](43d8001)) * simplify message payload to be compatible with firefox ([5e5a633](5e5a633)) ### Features * add service worker and pwa capabilities ([#550](#550)) ([225069e](225069e)), closes [#580](#580) [#582](#582) [#592](#592) * allow RegEx for filter patterns in d2.config.js ([9699330](9699330)) * use new headerbar with online status indicator ([#626](#626)) ([3bd7d37](3bd7d37)) ### BREAKING CHANGES * **dependencies:** This updates the app-platform to version 3 of the app-runtime. That means that this version of the app-platform will only work with apps that use version 3 of the app-runtime.
|
🎉 This PR is included in version 8.0.0-beta.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, when loading a PWA app for the first time while 'Update [SW] on reload' is checked in Chrome dev tools (in the Application tab), the app can get stuck in an infinite update loop which spams the 'Update' alert bars. This fix prevents that issue