Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "--arch=x64" option from leveldb rebuild options #237

Closed
arky opened this issue Jul 25, 2019 · 0 comments · Fixed by #240
Closed

Remove "--arch=x64" option from leveldb rebuild options #237

arky opened this issue Jul 25, 2019 · 0 comments · Fixed by #240

Comments

@arky
Copy link
Contributor

arky commented Jul 25, 2019 •
edited
Loading

Perhaps removing "--arch=x64" hard limit would allow building and running integration tests on windows 32-bit machines. There are still machines running older 32-bit windows operating system in the global south.

"rebuild-leveldb": "cd node_modules/leveldown && cross-env HOME=~/.electron-gyp node-gyp rebuild --target=2.0.7 --runtime=electron --arch=x64 --dist-url=https://atom.io/download/atom-shell",

mapeo-desktop/package.json

Line 29 in d52be7f

"rebuild-leveldb": "cd node_modules/leveldown && cross-env HOME=~/.electron-gyp node-gyp rebuild --target=2.0.7 --runtime=electron --arch=x64 --dist-url=https://atom.io/download/atom-shell",

arky added a commit to arky/mapeo-desktop that referenced this issue Jul 26, 2019
@arky
Remove --arch=x64 option
5b323c0 
Removing "--arch=x64" hard limit would allow building and running integration tests on windows 32-bit machines. Without this option, the arch setting will be picked from environment.  

Fixes digidem#237
@arky arky mentioned this issue Jul 26, 2019
Merged
gmaclennan pushed a commit that referenced this issue Jul 26, 2019
@arky @gmaclennan
Remove --arch=x64 option
7ace456 
Removing "--arch=x64" hard limit would allow building and running integration tests on windows 32-bit machines. Without this option, the arch setting will be picked from environment.  

Fixes #237
@arky arky mentioned this issue Mar 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove --arch=x64 option arky/mapeo-desktop
1 participant
@arky