Remove --arch=x64 option #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing "--arch=x64" hard limit would allow building and running integration tests on windows 32-bit machines. Without this option, the arch setting will be picked from environment. Fixes digidem#237
|
Thanks @arky I don't know why we had the x64 limit before. This looks good. I tried cleaning the caches on Travis to see if that fixes build failures on travis, which do not seem related to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing "--arch=x64" hard limit would allow building and running integration tests on windows 32-bit machines. Without this option, the arch setting will be picked from environment.
Fixes #237
Tested on Windows 7 32-bit machine