Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark locations as closed by default during CSV import #2784

Merged
merged 1 commit into from
May 7, 2024

Conversation

timobrembeck
Copy link
Member

Short description

Mark locations as closed by default during CSV import

Resolved issues

Fixes: #2783


Pull Request Review Guidelines

@timobrembeck timobrembeck requested a review from a team as a code owner May 6, 2024 18:16
Copy link

codeclimate bot commented May 6, 2024

Code Climate has analyzed commit efcd987 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 81.7% (0.0% change).

View more on Code Climate.

@JoeyStk JoeyStk mentioned this pull request May 6, 2024
@JoeyStk JoeyStk added the prio: high Needs to be resolved ASAP. label May 6, 2024
Copy link
Collaborator

@PeterNerlich PeterNerlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test this out, but as this is so concise I deduced that this should achieve the desired result from the change diff itself, assuming that old code was properly fulfilling its intention.
(please tell me if we regard this improper and dangerous even on PRs this short)

integreat_cms/release_notes/current/unreleased/2783.yml Outdated Show resolved Hide resolved
@timobrembeck timobrembeck force-pushed the feature/poi-import-default-closed branch from f87f0f6 to efcd987 Compare May 6, 2024 21:03
Copy link
Member

@MizukiTemma MizukiTemma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@timobrembeck timobrembeck merged commit 8a625c3 into develop May 7, 2024
5 checks passed
@timobrembeck timobrembeck deleted the feature/poi-import-default-closed branch May 7, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: high Needs to be resolved ASAP.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Treat missing opening hours as closed when importing POIs from CSV
4 participants