Various improvements to 'doctl serverless' #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge main into feature/serverless
* Add support for triggers * Add lastRun field to trigger list output * Hide commands we won't be supporting in EA day 1 * Bump deployer version to pick up bug fix * Fix error handling in services related to triggers Many calls were not checking for errors. * Switch to latest API Change both the triggers command (native to doctl) and the deployer version (which affects the semantics of deploy/undeploy). * Pick up latest deployer (triggers bug fix) * Remove support for prototype API and clean up code * Fix unit tests * Fix misleading comment * Remove added complexity due to successive change * Add filtering by function when listing triggers * Fix omitted code in DeleteTrigger * Guard triggers get/list with status check Otherwise, the credentials read fails with a cryptic error instead of an informative one when you are not connected to a namespace.
Merge latest `main` changes into `feature/serverless`
This completes the elimination of plugin usage in doctl sls fn and the functions.go source file.
I believe this happened in merge conflict resolution during the recent rebase.
Affects what happens when a failure occurs in the middle of deleting functions and triggers together.
…lugin Finish eliminating plugin usage in 'doctl sls functions' + testing improvements
* WIP for converting activations to direct OW flows * Finish recoding 'activations get' in native doctl Tests still to come * Convert the support for sls actv result Tests not converted yet * Generate latet mocks * Fix some comments * Use more realistic timestampes * Revise tests for new paths. Still no output check * Tests are now doing meaningful output comparison Fixed some bugs found once tests were really effective
Re-writes activations list command subtree in Go
…n-feature Incorporate main in feature
…-redux Main incorporation (deja vu all over again)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges
feature/serverlessintomainas part of a plan to stop using the feature branch to stage everything. We may resurrect it to stage large multi-PR multi-developer changes in the future, but, for now, we will be opening pull requests directly againstmain.The changes being merged here are all internal-facing. There is a substantial reduction in the number of commands that use the serverless plugin and a corresponding increase in the number of commands coded natively as part of doctl and going more directly to the appropriate remote endpoints via https. There are a couple of hidden flags on the
connectcommand that allow it to be used with test backends (not intended for normal customer use). Otherwise, behavior should be preserved.