Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom repeat captions #1428

Merged
merged 7 commits into from
Aug 22, 2024
Merged

Custom repeat captions #1428

merged 7 commits into from
Aug 22, 2024

Conversation

shubham1g5
Copy link
Contributor

Product Description

Adds ability to specify custom captions for repeat groups.

Spec

Safety Assurance

Safety story

no model change, verified with tests

Automated test coverage

PR adds a test to verify models plus there is a functional test in corresponding FP PR.

QA Plan

NA

  • This PR can be deployed after merge with no further considerations.
  • This PR can be reverted after deploy with no further considerations.
  • The set of people pinged as reviewers is appropriate for the level of risk of the change.

Duplicate PR

Automatically duplicate this PR as defined in contributing.md.

Formplayer: dimagi/formplayer#1615

@shubham1g5 shubham1g5 marked this pull request as ready for review August 21, 2024 08:22
@shubham1g5 shubham1g5 merged commit 65233a6 into formplayer Aug 22, 2024
2 checks passed
@shubham1g5 shubham1g5 deleted the customRepeatCaptions branch August 22, 2024 05:58
@shubham1g5 shubham1g5 restored the customRepeatCaptions branch August 22, 2024 05:59
@shubham1g5
Copy link
Contributor Author

duplicate this PR 6d719c3 9189a58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants