Custom Repeat Captions Support #1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
shubham1g5
requested review from
snopoke,
AddisonDunn,
Robert-Costello and
Jtang-1
Jtang-1
approved these changes
Aug 20, 2024
| @@ -44,7 +44,7 @@ public void testRepeatNonCountedSimple() throws Exception { | |||
| assert (tree.length == 2); | |||
| QuestionBean dummyNode = tree[1]; | |||
| assertEquals("false", dummyNode.getExists()); | |||
| assertEquals("Add a new question3", dummyNode.getAddChoice()); | |||
| assertEquals("Add Empty Caption Label", dummyNode.getAddChoice()); | |||
There was a problem hiding this comment.
I think it's worth adding back a test that checks the default text is correct
There was a problem hiding this comment.
Added in 3c381eb
Jtang-1
approved these changes
Aug 21, 2024
| @@ -131,20 +132,8 @@ public static JSONObject parseQuestionType(FormEntryModel model, JSONObject obj) | |||
| } | |||
|
|
|||
| private static String getRepeatAddText(FormEntryCaption prompt) { | |||
| String promptText = prompt.getLongText(); | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1615 +/- ##
============================================
- Coverage 70.34% 70.15% -0.19%
+ Complexity 2065 1997 -68
============================================
Files 255 254 -1
Lines 7968 7878 -90
Branches 740 739 -1
============================================
- Hits 5605 5527 -78
+ Misses 2078 2069 -9
+ Partials 285 282 -3 ☔ View full report in Codecov by Sentry. |
Jtang-1
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
https://dimagi.atlassian.net/browse/USH-4710
Adds ability to specify custom captions for repeat groups.
Spec
Safety Assurance
Safety story
Automated test coverage
We have test coverage to check for add captions that this PR changes in accordance to new behaviour.
QA Plan
Not planning
cross-request: dimagi/commcare-core#1428