feat(Interaction): add .commandType property to `CommandInteracti…

…on` and `AutocompleteInteraction` (#7357)
discordjs · Jan 30, 2022 · 567db60 · 567db60
1 parent fbb1d03
commit 567db60
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 12 deletions.
diff --git a/packages/discord.js/src/structures/AutocompleteInteraction.js b/packages/discord.js/src/structures/AutocompleteInteraction.js
@@ -30,6 +30,12 @@ class AutocompleteInteraction extends Interaction {
      */
     this.commandName = data.data.name;
 
+    /**
+     * The invoked application command's type
+     * @type {ApplicationCommandType.ChatInput}
+     */
+    this.commandType = data.data.type;
+
     /**
      * Whether this interaction has already received a response
      * @type {boolean}

diff --git a/packages/discord.js/src/structures/CommandInteraction.js b/packages/discord.js/src/structures/CommandInteraction.js
@@ -33,6 +33,12 @@ class CommandInteraction extends Interaction {
      */
     this.commandName = data.data.name;
 
+    /**
+     * The invoked application command's type
+     * @type {ApplicationCommandType}
+     */
+    this.commandType = data.data.type;
+
     /**
      * Whether the reply to this interaction has been deferred
      * @type {boolean}

diff --git a/packages/discord.js/src/structures/ContextMenuCommandInteraction.js b/packages/discord.js/src/structures/ContextMenuCommandInteraction.js
@@ -26,13 +26,6 @@ class ContextMenuCommandInteraction extends CommandInteraction {
      * @type {Snowflake}
      */
     this.targetId = data.data.target_id;
-
-    /**
-     * The type of the target of the interaction; either {@link ApplicationCommandType.User}
-     * or {@link ApplicationCommandType.Message}
-     * @type {ApplicationCommandType.User|ApplicationCommandType.Message}
-     */
-    this.targetType = data.data.type;
   }
 
   /**

diff --git a/packages/discord.js/src/structures/Interaction.js b/packages/discord.js/src/structures/Interaction.js
@@ -164,31 +164,31 @@ class Interaction extends Base {
    * @returns {boolean}
    */
   isChatInputCommand() {
-    return this.isCommand() && typeof this.targetId === 'undefined';
+    return this.isCommand() && this.commandType === ApplicationCommandType.ChatInput;
   }
 
   /**
    * Indicates whether this interaction is a {@link ContextMenuCommandInteraction}
    * @returns {boolean}
    */
   isContextMenuCommand() {
-    return this.isCommand() && typeof this.targetId !== 'undefined';
+    return this.isCommand() && [ApplicationCommandType.User, ApplicationCommandType.Message].includes(this.commandType);
   }
 
   /**
    * Indicates whether this interaction is a {@link UserContextMenuCommandInteraction}
    * @returns {boolean}
    */
   isUserContextMenuCommand() {
-    return this.isContextMenuCommand() && this.targetType === ApplicationCommandType.User;
+    return this.isContextMenuCommand() && this.commandType === ApplicationCommandType.User;
   }
 
   /**
    * Indicates whether this interaction is a {@link MessageContextMenuCommandInteraction}
    * @returns {boolean}
    */
   isMessageContextMenuCommand() {
-    return this.isContextMenuCommand() && this.targetType === ApplicationCommandType.Message;
+    return this.isContextMenuCommand() && this.commandType === ApplicationCommandType.Message;
   }
 
   /**

diff --git a/packages/discord.js/typings/index.d.ts b/packages/discord.js/typings/index.d.ts
@@ -326,6 +326,7 @@ export abstract class CommandInteraction<Cached extends CacheType = CacheType> e
   public channelId: Snowflake;
   public commandId: Snowflake;
   public commandName: string;
+  public commandType: ApplicationCommandType;
   public deferred: boolean;
   public ephemeral: boolean | null;
   public replied: boolean;
@@ -705,6 +706,7 @@ export class AutocompleteInteraction<Cached extends CacheType = CacheType> exten
   public channelId: Snowflake;
   public commandId: Snowflake;
   public commandName: string;
+  public commandType: ApplicationCommandType.ChatInput;
   public responded: boolean;
   public options: Omit<CommandInteractionOptionResolver<Cached>, 'getMessage'>;
   public inGuild(): this is AutocompleteInteraction<'raw' | 'cached'>;
@@ -785,7 +787,6 @@ export class ContextMenuCommandInteraction<Cached extends CacheType = CacheType>
     | 'getSubcommand'
   >;
   public targetId: Snowflake;
-  public targetType: Exclude<ApplicationCommandType, ApplicationCommandType.ChatInput>;
   public inGuild(): this is ContextMenuCommandInteraction<'raw' | 'cached'>;
   public inCachedGuild(): this is ContextMenuCommandInteraction<'cached'>;
   public inRawGuild(): this is ContextMenuCommandInteraction<'raw'>;