Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Interaction): add .commandType property to CommandInteraction and AutocompleteInteraction #7357

Merged
merged 3 commits into from
Jan 30, 2022
Merged

feat(Interaction): add .commandType property to CommandInteraction and AutocompleteInteraction #7357

merged 3 commits into from
Jan 30, 2022

Conversation

Matthew1177
Copy link
Contributor

@Matthew1177 Matthew1177 commented Jan 27, 2022 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:
Adds CommandInteraction#commandType and AutocompleteInteraction#commandType and removes ContextMenuCommandInteraction#targetType.

This PR moves ContextMenuCommandInteraction#targetType to CommandInteraction#commandType and introduces AutocompleteInteraction#commandType for forward-compatability.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@iCrawl iCrawl added this to the discord.js v14 milestone Jan 28, 2022
@iCrawl iCrawl merged commit 567db60 into discordjs:main Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imranbarbhuiya imranbarbhuiya imranbarbhuiya left review comments

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
interactions packages:discord.js semver:major
Projects
discord.js
Archived in project
Milestone
discord.js v14
Development

Successfully merging this pull request may close these issues.
6 participants
@Matthew1177 @vladfrangu @iCrawl @kyranet @SpaceEEC @imranbarbhuiya