-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Make message components agnostic components #7040
Refactor: Make message components agnostic components #7040
Conversation
Just realized that this is going to need to be semver: major, because it changes the type of |
I don’t think there’s a use case where that would break though is there? |
The only place I can think of is using |
Yeah there’s always that but I don’t think anyone would be doing this here. You can also make the old classes extend the new ones and I think the instanceof checks wouldn’t break here, right? This would work since I believe all properties and methods are the same right |
If I made the new classes extend the old ones it would defeat the purpose of this PR. |
My suggestion is to make the old ones extend the new ones. The properties are the same, but documented differently (at least how I see it) so it wouldn’t defeat the purpose would it? |
Perhaps, but then you might run into the issue where |
I don't think anyone in their right mind would do such a thing but yeah you're right :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit otherwise LGTM to me
Co-authored-by: Vlad Frangu <[email protected]>
Please rebase, there are merge conflicts. |
This needs a rebease. |
So I'm probably going to close this PR and open another one later that uses the message components from builders instead. |
Superceded by #7195 |
Please describe the changes this PR makes and why it should be merged:
This deprecates all otherMessage*
types, so this shouldn't be breaking.It's breaking
This makes all components regardless of being a message component, or a modal component all inherit from the same base, and have no difference in variance between message and modal implementations. This is key refactor needed for the modal PR (#7023), and prevents future class proliferation of other component type variants.
Status and versioning classification: