-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove discord.js enums and use discord-api-types enums instead #7077
refactor: remove discord.js enums and use discord-api-types enums instead #7077
Conversation
f534c45
to
c28082b
Compare
c28082b
to
fbce789
Compare
fbce789
to
47ab69a
Compare
af3b7f2
to
7b09d93
Compare
packages/discord.js/src/structures/interfaces/TextBasedChannel.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR makes me very happy, we're finally getting PascalCased enums!
Just a couple of things :P
22026c8
to
e2b575c
Compare
The API documents pretty much every type as UPPER_CASE (example), why are we switching to PascalCase? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were not updated:
This was removed from the constants. So it should be removed from here too. However, it's being used in other files (the doc type) and it doesn't exist anymore
This type should be removed:
I fixed all of these except for the components, as stated in the PR description those will updated in another PR. |
Please describe the changes this PR makes and why it should be merged:
TODO:
Note: I won't be updating the enums for any components. I'll wait for #7040 to be merged before I modify anything with components.
Status and versioning classification:
Please move lines that apply to you out of the comment: