fix: follow discord-api-types package's type
#7267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
ghost
changed the title
discord-api-types packagediscord-api-types package's type
kyranet
approved these changes
Jan 14, 2022
|
This change was already proposed on another PR and rejected by @iCrawl so this will probably have the same faith |
But it's fact that those methods are broken. how to fix the problem without following dapi-types package's way? |
|
Not use -dev is a way. If you need interaction locales theres also 13.6.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
After this,
CommandInteractionOptionResolver#getXonly acceptsdiscord-api-types's type. It throws an error because old thing is ALL UPPERCASE, whilediscord-api-typesusing PascalCase.Status and versioning classification: