Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SelectMenu): set placeholder max to 150 #7538

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Feb 23, 2022

Please describe the changes this PR makes and why it should be merged:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Copy link
Member

@Jiralite Jiralite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind updating this test?

const longStr =
'looooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooong';

expect(() => selectMenu().setPlaceholder(longStr)).toThrowError();

It seems the string is not long enough now.

@suneettipirneni
Copy link
Member

Do you mind updating this test?

const longStr =
'looooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooong';

expect(() => selectMenu().setPlaceholder(longStr)).toThrowError();

It seems the string is not long enough now.

string#repeat helps here 😄

@almeidx
Copy link
Member Author

almeidx commented Mar 9, 2022

Upstream pr landed

@SpaceEEC SpaceEEC removed the discord label Mar 9, 2022
@iCrawl iCrawl merged commit dcd4797 into discordjs:main Mar 10, 2022
@almeidx almeidx deleted the placeholder branch March 10, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants