Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(SelectMenu): set placeholder max to 150 #7538

Merged
merged 1 commit into from
Mar 10, 2022
Merged

fix(SelectMenu): set placeholder max to 150 #7538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/builders/__tests__/components/selectMenu.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@ import { SelectMenuComponent, SelectMenuOption } from '../../src/index';
const selectMenu = () => new SelectMenuComponent();
const selectMenuOption = () => new SelectMenuOption();

const longStr =
'looooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooong';
const longStr = 'a'.repeat(256);

const selectMenuOptionData: APISelectMenuOption = {
label: 'test',
Expand Down
2 changes: 1 addition & 1 deletion packages/builders/src/components/Assertions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export const buttonLabelValidator = z.string().nonempty().max(80);

export const buttonStyleValidator = z.number().int().min(ButtonStyle.Primary).max(ButtonStyle.Link);

export const placeholderValidator = z.string().max(100);
export const placeholderValidator = z.string().max(150);
export const minMaxValidator = z.number().int().min(0).max(25);

export const optionsValidator = z.object({}).array().nonempty();
Expand Down