Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: update release notes and bump version #44

Merged
merged 2 commits into from
Jan 31, 2022

Conversation

SamSaffron
Copy link
Member

No description provided.


- Ruby 2.6 is EOL support removed

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we should remove Ruby 2.6 from our Ruby test matrix as part of this change:

ruby: ["3.0", "2.7", "2.6"]

@@ -1,4 +1,4 @@
# frozen_string_literal: true
module MiniSql
VERSION = "1.1.3"
VERSION = "1.2.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is failing on an error in the gem so I'm not sure if we should do a version bump until we can be sure that the gem itself isn't broken?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes... on it ... it seems I merged a problem PR a while back it forgot to require 'set'

- Correct deprecation
- increase test matrix and remove ruby 2.6
- include missing "set" dependency
@SamSaffron
Copy link
Member Author

@tgxworld should be fixed now.

@tgxworld
Copy link

The tests are still broken 😁. In Ruby 3.1 and Ruby-head it looks like rubocop error is causing it. In 3.0 though, it likes we may have a leak? Unlikely to be related to this PR though but I think a green build would be great before we do a minor version bump.

Copy link

@tgxworld tgxworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here looks good so approving first 👍

@SamSaffron SamSaffron merged commit 20514a4 into discourse:main Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants