Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS: update release notes and bump version #44

Merged
merged 2 commits into from
Jan 31, 2022
Merged

DOCS: update release notes and bump version #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8ad320
DOCS: update release notes and bump version
SamSaffron Jan 31, 2022
0f71774
Various fixes
SamSaffron Jan 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: ["3.0", "2.7", "2.6"]
ruby: ["3.1", "3.0", "2.7"]
experimental: [false]
include:
- ruby: ruby-head
Expand Down
3 changes: 2 additions & 1 deletion CHANGELOG
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
Pending:
2022-31-01 - 1.2.0

- Ruby 2.6 is EOL support removed
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we should remove Ruby 2.6 from our Ruby test matrix as part of this change:

mini_sql/.github/workflows/ci.yml

Line 40 in bd46c55

ruby: ["3.0", "2.7", "2.6"]

- FIX: when multiple params shared a prefix inline encoder may work in unexpected ways
- FEATURE: add sql_literal for injecting sql in sql builder

Expand Down
3 changes: 3 additions & 0 deletions lib/mini_sql.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
# we need this for a coder
require "bigdecimal"

# used for builder
require "set"

require_relative "mini_sql/version"
require_relative "mini_sql/connection"
require_relative "mini_sql/deserializer_cache"
Expand Down
2 changes: 1 addition & 1 deletion lib/mini_sql/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# frozen_string_literal: true
module MiniSql
VERSION = "1.1.3"
VERSION = "1.2.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is failing on an error in the gem so I'm not sure if we should do a version bump until we can be sure that the gem itself isn't broken?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes... on it ... it seems I merged a problem PR a while back it forgot to require 'set'

end
2 changes: 1 addition & 1 deletion test/test_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def pg_connection(options = {})
args[name] = val
end
end
pg_conn = PG.connect(args)
pg_conn = PG.connect(**args)
MiniSql::Connection.get(pg_conn, options)
end

Expand Down