Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistency fix proposal #23

Merged
merged 1 commit into from
Mar 30, 2018
Merged

consistency fix proposal #23

merged 1 commit into from
Mar 30, 2018

Conversation

astoliar
Copy link
Contributor

This is not a translation problem, I think this is a small issue of consistency in the example that might confuse someone.

The example is about mutability qualifiers but also shows how to use the typeof( .. ).tostring() to obtain a human-readable string of that type. At line 18 it says:

const int* cm = &m;
writeln("cm: ", typeof(cm).stringof);

and few lines down (line 37) it says:

const int* cv = &v;
writeln("*cv: ", typeof(cv).stringof);

there is no consistency between the two sections of the example. If the first writln text is correct then the text of the second writeln should say "cv" and not "*cv". You know, the output of typeof(*cv).stringof is not the same that typeof(cv).stringof, like "*cv: const(int*)" is not the same that "cv: const(int*)".

Assuming that the * must be removed from the second writeln, I just sent a merge request with this proposal. This issue also exists in the main version of the tour. I will propose the same change there if you all agree with it.

@csantander
Copy link
Contributor

I think we should do it the other way around: propose the change upstream and we'll merge it here once that one is approved

@wilzbach
Copy link
Member

FYI upstream is far from perfect.I didn't write it, just somehow ended up "adopting" it because I thought the tour is very important for D.
So improvements to upstream are almost always very welcome.

@csantander
Copy link
Contributor

Along the same lines, I don't own the Spanish translation, so if anyone else thinks that any PRs (including this one) should be merged, please go ahead. In cases like this one, my opinion is that translations should try to stay as close as possible to the original work and perhaps there's a reason why the original is the way it is. I don't disagree with the PR, I would just like to make sure we're keeping in sync with the English version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants