Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate SCOPE.compiles for nested functions in traits(compiles) blocks #14846

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

RazvanN7
Copy link
Contributor

@RazvanN7 RazvanN7 commented Jan 25, 2023

While trying to fix [1][2], I noticed that when a function's body is semantically analyzed the SCOPE.compiles field is always set to 0. Digging through what has caused this, I noticed that this was done to prevent traits(compiles) blocks from affecting the inferred attributes of the outer function. However, this has the side effect that functions that are nested in the traits(compiles) lose this information. This information is necessary for [2], which currently works around this issue by using one of the 4 different ways of checking if we are in a speculative scope, but should use SCOPE.compiles after this is merged. I suspect that this will also make it easy to get rid of the useless complexity added by [3].

[1] https://issues.dlang.org/show_bug.cgi?id=23650
[2] #14844
[3] #7897

@RazvanN7 RazvanN7 added the Blocking Other Work review and pulling should be a priority label Jan 25, 2023
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14846"

Copy link
Contributor

@dkorpel dkorpel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for untangling this mess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking Other Work review and pulling should be a priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants