Propagate SCOPE.compiles for nested functions in traits(compiles) blocks #14846
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to fix [1][2], I noticed that when a function's body is semantically analyzed the SCOPE.compiles field is always set to 0. Digging through what has caused this, I noticed that this was done to prevent traits(compiles) blocks from affecting the inferred attributes of the outer function. However, this has the side effect that functions that are nested in the traits(compiles) lose this information. This information is necessary for [2], which currently works around this issue by using one of the 4 different ways of checking if we are in a speculative scope, but should use SCOPE.compiles after this is merged. I suspect that this will also make it easy to get rid of the useless complexity added by [3].
[1] https://issues.dlang.org/show_bug.cgi?id=23650
[2] #14844
[3] #7897