Fix Issue 23650 - Using typeid with struct defined in __traits(compiles, ...) causes linker error #14844

RazvanN7 · 2023-01-24T13:14:35Z

Currently blocking: #14664

If a typeid is encountered in a speculative context it should not generate any Typeinfo.
The actual typeinfo ast node is generated so that assignments such as Typeinfo a = typeid(b)
still work.

dlang-bot · 2023-01-24T13:14:41Z

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
I have provided a detailed rationale explaining my changes
New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	23650	blocker	Using typeid with struct defined in in __traits(compiles, ...) causes linker error

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

Regression or critical bug fixes should always target the stable branch. Learn more about rebasing to stable or the D release process.

To target stable perform these two steps:

Rebase your branch to upstream/stable:

git rebase --onto upstream/stable upstream/master

Change the base branch of your PR to stable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14844"

RazvanN7 · 2023-01-24T13:17:29Z

cc @teodutu

RazvanN7 · 2023-01-25T10:43:08Z

compiler/src/dmd/semantic3.d

@@ -342,6 +342,8 @@ private extern(C++) final class Semantic3Visitor : Visitor
            sc2.aligndecl = null;
            if (funcdecl.ident != Id.require && funcdecl.ident != Id.ensure)
                sc2.flags = sc.flags & ~SCOPE.contract;
+            if (sc2.flags & SCOPE.compile)
+                funcdecl.skipCodegen = true;
            sc2.flags &= ~SCOPE.compile;


Currently dmd has multiple ways of checking for speculative context, each with its subtle differences:

sc.minst and sc.tinst are both null.

sc.flags & SCOPE.compile

FuncDeclaration.skipCodegen

FuncDeclaration.isCompileTimeOnly

Here, SCOPE.compile is randomly cleared because it is used for attribute inference in a different place.
The entire situation is crazy...

I'm looking into simplifying the mess, but until that point, I'm using skipCodegen to signal typeid that we are in a speculative context. I tried all of the above, but only skipCodegen works.

…es, ...) causes linker error

Reverting dlang#14844, which caused such missing TypeInfos, *and* making sure the special TypeInfo members are fully analyzed and ready for codegen (otherwise hitting an assertion).

Reverting dlang#14844, which caused such missing TypeInfos, *and* making sure the special TypeInfo members are fully analyzed and ready for codegen (otherwise hitting an assertion for the real-world project).

Reverting #14844, which caused such missing TypeInfos, *and* making sure the special TypeInfo members are fully analyzed and ready for codegen (otherwise hitting an assertion for the real-world project).

Reverting dlang#14844, which caused such missing TypeInfos, *and* making sure the special TypeInfo members are fully analyzed and ready for codegen (otherwise hitting an assertion for the real-world project).

* Document template instance duplication status as part of its field documentation. (#16643) * Fix Bugzilla 24599 - Wrongly elided TypeInfo emission (#15868) Reverting #14844, which caused such missing TypeInfos, *and* making sure the special TypeInfo members are fully analyzed and ready for codegen (otherwise hitting an assertion for the real-world project). * Reorganize backend build files to match target and make more similar per line (#16672) * Remove redundant suggestions on linker errors (#16711) * Fix bugzilla 24337 - Segfault when printing an int[] cast from a string (#16729) * Add BitFieldStyle.Gcc_Clang_ARM Required for 32-bit ARM, and non-Apple 64-bit ARM targets. The only difference to `Gcc_Clang` is that anonymous and 0-length bit-fields do contribute to the aggregate alignment. Caught by existing proper C interop tests in runnable_cxx/testbitfields.d on such targets. The hardcoded bad tests in runnable/{bitfieldsposix64.c,dbitfieldsposix64.d} however now fail after the fix, on such targets again. * [refactor to `TargetC.contributesToAggregateAlignment(BitFieldDeclaration)` hook] * Fix Bugzilla Issue 24687 - [REG2.110] Cannot cast string-imports to select overload anymore * Also make deprecationSupplemental adhere to error limit (#16779) Co-authored-by: Dennis Korpel <[email protected]> * Fix bugzilla 24699 - [REG2.108] No short-circuit evaluation of mixing template bool argument * Fix bugzilla 24731 - IFTI cannot handle integer expressions (#16822) * Fix Bugzilla Issue 24760 - ICE on variadic after default argument * Fix bugzilla 24790 - -vcg-ast ICE on lowered assign exp (#16914) Co-authored-by: Dennis Korpel <[email protected]> * Fix bugzilla 24764 - ICE when -vcg-ast prints imported invariant (#16917) Co-authored-by: Dennis Korpel <[email protected]> * Fix bugzilla 24431 - dmd -vcg-ast crashes printing failed template in… (#16916) --------- Co-authored-by: Richard (Rikki) Andrew Cattermole <[email protected]> Co-authored-by: Martin Kinkelin <[email protected]> Co-authored-by: Dennis <[email protected]> Co-authored-by: Martin Kinkelin <[email protected]> Co-authored-by: Martin Kinkelin <[email protected]> Co-authored-by: RazvanN7 <[email protected]> Co-authored-by: Dennis Korpel <[email protected]> Co-authored-by: Dennis Korpel <[email protected]>

RazvanN7 added the Blocking Other Work review and pulling should be a priority label Jan 24, 2023

RazvanN7 requested a review from ibuclaw as a code owner January 24, 2023 13:14

dlang-bot added the Bug Fix label Jan 24, 2023

RazvanN7 changed the title ~~Fix Issue 23650 - Using typeid with struct defined in in __traits(compiles, ...) causes linker error~~ Fix Issue 23650 - Using typeid with struct defined in __traits(compiles, ...) causes linker error Jan 24, 2023

RazvanN7 force-pushed the Issue_23650 branch 3 times, most recently from 68310f1 to f592ee3 Compare January 25, 2023 10:33

RazvanN7 commented Jan 25, 2023

View reviewed changes

RazvanN7 mentioned this pull request Jan 25, 2023

Propagate SCOPE.compiles for nested functions in traits(compiles) blocks #14846

Merged

RazvanN7 force-pushed the Issue_23650 branch from f592ee3 to e1b41c4 Compare January 25, 2023 13:21

Fix Issue 23650 - Using typeid with struct defined in __traits(compil…

8c41513

…es, ...) causes linker error

RazvanN7 force-pushed the Issue_23650 branch from e1b41c4 to 8c41513 Compare January 25, 2023 15:41

dkorpel approved these changes Jan 26, 2023

View reviewed changes

RazvanN7 merged commit 48c3e38 into dlang:master Jan 26, 2023

kinke mentioned this pull request Nov 27, 2023

[stable] Fix Bugzilla 24599 - Wrongly elided TypeInfo emission #15868

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Issue 23650 - Using typeid with struct defined in __traits(compiles, ...) causes linker error #14844

Fix Issue 23650 - Using typeid with struct defined in __traits(compiles, ...) causes linker error #14844

RazvanN7 commented Jan 24, 2023 •

edited

Loading

dlang-bot commented Jan 24, 2023 •

edited

Loading

RazvanN7 commented Jan 24, 2023

RazvanN7 Jan 25, 2023 •

edited

Loading

Fix Issue 23650 - Using typeid with struct defined in __traits(compiles, ...) causes linker error #14844

Fix Issue 23650 - Using typeid with struct defined in __traits(compiles, ...) causes linker error #14844

Conversation

RazvanN7 commented Jan 24, 2023 • edited Loading

dlang-bot commented Jan 24, 2023 • edited Loading

Bugzilla references

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

Testing this PR locally

RazvanN7 commented Jan 24, 2023

RazvanN7 Jan 25, 2023 • edited Loading

Choose a reason for hiding this comment

RazvanN7 commented Jan 24, 2023 •

edited

Loading

dlang-bot commented Jan 24, 2023 •

edited

Loading

RazvanN7 Jan 25, 2023 •

edited

Loading