Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge stable into master #2037

Merged
merged 4 commits into from
Nov 17, 2020
Merged

Merge stable into master #2037

merged 4 commits into from
Nov 17, 2020

Conversation

Geod24
Copy link
Member

@Geod24 Geod24 commented Nov 17, 2020

To pick up the GH action fix.

Geod24 and others added 4 commits September 28, 2020 13:44
getPackageSuppliers already handles SkipPackageSuppliers.none correctly,
no need for an extra check.
For some reason, dflags and lflags were not using the 'add' convenience function,
which allows to deduplicate flags.
As a result some flags, especially link flags which propagate upwards,
ended up taking half of the command line length.
PR #2016 introducted a de-duplication strategy that is too eager and corrupts argument chains, such as "-framework CoreServices -framework CoreFoundation" where the "-framework" argument needs to be duplicated for each framework.

This reverts commit 10bea6f.
@dlang-bot
Copy link
Collaborator

Thanks for your pull request, @Geod24!

@Geod24 Geod24 merged commit 8ef43bd into master Nov 17, 2020
@Geod24 Geod24 mentioned this pull request Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants