Rework the MAP metric. #8931
Merged
Rework the MAP metric. #8931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The new implementation is more restricted as only binary label is accepted. The previous implementation converts value greater than 1 as 1. - Deterministic GPU. (no atomic add). - Precise definition of MAP.
trivialfis
commented
Mar 17, 2023
| pytestmark = tm.timeout(30) | ||
|
|
||
|
|
||
| def comp_training_with_rank_objective( |
There was a problem hiding this comment.
The test is the same as the old one, just converted to pytest style using pytest.mark.parametrize, along with cache for the mq2008 dataset to prevent downloading it repeatedly.
RAMitchell
approved these changes
Mar 22, 2023
This was referenced Apr 3, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #8822 .