Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "munge-i386" to add "--build-context" in "docker buildx build" lines #80

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

tianon
Copy link
Member

@tianon tianon commented Aug 1, 2023

Without this, we end up building against the wrong image due to a bug in buildx/buildkit (docker/buildx#1886). 😞

… lines

Without this, we end up building against the wrong image due to a bug in buildx/buildkit. 😞
@tianon
Copy link
Member Author

tianon commented Aug 1, 2023

(Because of this, we haven't noticed that RabbitMQ is failing to build on i386 and failing with a similar problem on arm32v7 😭)

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2023

Codecov Report

Merging #80 (d3dede4) into master (2ff9004) will not change coverage.
Report is 7 commits behind head on master.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   73.10%   73.10%           
=======================================
  Files           7        7           
  Lines         714      714           
=======================================
  Hits          522      522           
  Misses        162      162           
  Partials       30       30           

@tianon
Copy link
Member Author

tianon commented Aug 1, 2023

Oh, I guess we could/should maybe add --platform linux/386 also?

@yosifkit
Copy link
Member

yosifkit commented Aug 1, 2023

Oh, I guess we could/should maybe add --platform linux/386 also?

Agreed.

@tianon
Copy link
Member Author

tianon commented Sep 26, 2023

(oh, #81 is very related, although not exactly the same since munge-i386 is separate)

@yosifkit
Copy link
Member

Added a commit to address the --platform flag by building upon the provided flag from #81. (So now 81 is necessary for all the functionality here).

@tianon
Copy link
Member Author

tianon commented Oct 24, 2023

More heinous every time we touch it 😀

LGTM

@yosifkit yosifkit merged commit a70de23 into docker-library:master Oct 24, 2023
6 checks passed
@yosifkit yosifkit deleted the i386-build-context branch October 24, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants