Fix OpenSSL platform detection, especially for 32bit arches #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to a bug in buildx/buildkit, our CI failed to catch that i386 has been failing to build (for some reason, OpenSSL was detecting it as `linux-x32` instead of `linux-x86`), and our arm32v7 builds were failing for a similar reason (assuming "armv4" instead of v7). This makes the detection explicit based on the userspace architecture instead.
lukebakken
approved these changes
Aug 1, 2023
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Aug 1, 2023
Changes: - docker-library/rabbitmq@ffecd69: Merge pull request docker-library/rabbitmq#657 from infosiftr/i386-arm32 - docker-library/rabbitmq@23170d7: Fix OpenSSL platform detection, especially for 32bit arches - docker-library/rabbitmq@0720727: Update 3.9 to otp 25.3.2.5 - docker-library/rabbitmq@a52f4d1: Update 3.12 to otp 25.3.2.5 - docker-library/rabbitmq@ccccce7: Update 3.11 to otp 25.3.2.5 - docker-library/rabbitmq@8ce2bd3: Update 3.10 to otp 25.3.2.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to a bug in buildx/buildkit (see docker-library/bashbrew#80, docker/buildx#1886), our CI failed to catch that i386 has been failing to build (for some reason, OpenSSL was detecting it as
linux-x32instead oflinux-x86), and our arm32v7 builds were failing for a similar reason (assuming "armv4" instead of v7).This makes the detection explicit based on the userspace architecture instead.