Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Kubernetes commands from experimental #1068

Merged
merged 1 commit into from
May 28, 2018
Merged

Remove Kubernetes commands from experimental #1068

merged 1 commit into from
May 28, 2018

Conversation

silvin-lubecki
Copy link
Contributor

- What I did
I removed the experimentalCli annotations and all the experimental code linked to the Kubernetes features.

- How to verify it

# Make sure the CLI is not experimental
$ docker version
Client:
...
 Experimental: false

# Check the help of stack commands with kubernetes orchestrator, it should list some kubernetes flags 
$ docker --orchestrator=kubernetes stack --help
...
      --kubeconfig string     Kubernetes config file

- Description for the changelog

  • Remove Kubernetes commands from experimental

- A picture of a cute animal (not mandatory but encouraged)
image

⚠️ Needs #1023 #1035 #1059 to be merged before that.

vdemeester
vdemeester approved these changes May 25, 2018
View reviewed changes
Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯
Let's wait for the required PR to get merge before merging this one though 👼

@silvin-lubecki silvin-lubecki changed the title [WIP] Remove Kubernetes commands from experimental Remove Kubernetes commands from experimental May 28, 2018
@silvin-lubecki silvin-lubecki force-pushed the remove-experimental-for-orchestrator branch from 271acef to 72fdc36 Compare May 28, 2018 10:25
@silvin-lubecki
Copy link
Contributor Author

Rebased

thaJeztah
thaJeztah requested changes May 28, 2018
View reviewed changes
cli/command/cli_test.go
expectedOrchestrator: "swarm",
expectedKubernetes: false,
expectedSwarm: true,
},
{
doc: "kubernetesConfigFile",
configfile: `{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a couple more "experimental": "enabled" below; think those can be removed as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

@silvin-lubecki silvin-lubecki force-pushed the remove-experimental-for-orchestrator branch from 72fdc36 to f2b75a8 Compare May 28, 2018 13:06
thaJeztah
thaJeztah approved these changes May 28, 2018
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdemeester vdemeester merged commit 824a0b4 into docker:master May 28, 2018
@GordonTheTurtle GordonTheTurtle added this to the 18.06.0 milestone May 28, 2018
@silvin-lubecki silvin-lubecki deleted the remove-experimental-for-orchestrator branch May 30, 2018 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@mat007 mat007 mat007 approved these changes

Assignees
No one assigned
Labels
area/kubernetes impact/changelog kind/experimental status/2-code-review
Projects
None yet
Milestone
18.06.0
Development

Successfully merging this pull request may close these issues.
5 participants
@silvin-lubecki @vdemeester @thaJeztah @mat007 @GordonTheTurtle