-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add network and target to build in v3.4 #430
Conversation
Signed-off-by: Daniel Nephin <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #430 +/- ##
=======================================
Coverage 46.28% 46.28%
=======================================
Files 194 194
Lines 16134 16134
=======================================
Hits 7467 7467
Misses 8278 8278
Partials 389 389 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐯
Seeing as multi-stage builds with targets were introduced as part of docker-ce stable 17.06, is there any chance this change will be part of any 17.06.x stable patch release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@sirlatrom |
cc @shin- just an FYI that we've added these to v3.4 |
@thaJeztah
package main
func main() {
}
FROM golang:1.7.3 as builder
WORKDIR /go/src/github.com/alexellis/href-counter/
RUN go get -d -v golang.org/x/net/html
COPY app.go .
RUN CGO_ENABLED=0 GOOS=linux go build -a -installsuffix cgo -o app .
FROM alpine:latest
RUN apk --no-cache add ca-certificates
WORKDIR /root/
COPY --from=builder /go/src/github.com/alexellis/href-counter/app .
CMD ["./app"]
version: '3.3'
services:
builder:
build:
context: .
target: builder
app:
build:
context: . Error message: $ docker stack deploy --compose-file docker-compose.yml mystack
services.builder.build Additional property target is not allowed
$ docker version
Client:
Version: 17.06.0-ce
API version: 1.30
Go version: go1.8.3
Git commit: 02c1d87
Built: Fri Jun 23 21:23:31 2017
OS/Arch: linux/amd64
Server:
Version: 17.06.0-ce
API version: 1.30 (minimum version 1.12)
Go version: go1.8.3
Git commit: 02c1d87
Built: Fri Jun 23 21:19:04 2017
OS/Arch: linux/amd64
Experimental: false |
Fixes #305
Related docker/compose#5011
This is basically a no-op, but it's good to keep them synced, and it will work when Compose uses the v3.4 schema.