Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compose-file: add some options that were missing in changes #10680

Merged
merged 1 commit into from
Apr 22, 2020

Conversation

thaJeztah
Copy link
Member

I noticed the network option for build was not documented, which was added in compose-file 2.2 (docker/compose#4997) and 3.4 (docker/cli#430), then saw some missing entries for the v3.1 and v3.2 format, so added those (probably more changes may be needed, but it didn't go through all versions)

@usha-mandya @ulyssessouza PTAL

@thaJeztah thaJeztah added the area/compose Relates to docker-compose.yml spec or docker-compose binary label Apr 21, 2020
@netlify
Copy link

netlify bot commented Apr 21, 2020

Deploy preview for docsdocker ready!

Built with commit dfb7338

https://deploy-preview-10680--docsdocker.netlify.app

@netlify
Copy link

netlify bot commented Apr 21, 2020

Deploy preview for docsdocker ready!

Built with commit 3caa2ca

https://deploy-preview-10680--docsdocker.netlify.app

Copy link
Member

@usha-mandya usha-mandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@ulyssessouza ulyssessouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usha-mandya usha-mandya merged commit 72f90f5 into docker:master Apr 22, 2020
@thaJeztah thaJeztah deleted the compose_build_network branch April 22, 2020 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/compose Relates to docker-compose.yml spec or docker-compose binary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants