-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --include-deps to push command #10044
Conversation
9d7d8c0
to
43bc5e8
Compare
While I don't expect many users to rely on this, I'm a bit concerned about another backward compatibility break. |
Codecov ReportBase: 76.98% // Head: 75.79% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## v2 #10044 +/- ##
==========================================
- Coverage 76.98% 75.79% -1.20%
==========================================
Files 2 2
Lines 252 252
==========================================
- Hits 194 191 -3
- Misses 51 53 +2
- Partials 7 8 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Fair point, I can definitely move it to a
Sure, can you point me to a good place to do this? I'm not familiar with this codebase to select a proper location myself. |
I didn't noticed you can just extract https://github.com/docker/compose/blob/v2/cmd/compose/up.go#L57-L66 into a func inside up.go and call it from both command - by the way, can also use it for |
also need to regenerate docs to reflect new flag using |
05e4e4a
to
8698af6
Compare
Signed-off-by: Gabriel Féron <[email protected]>
8698af6
to
e70b283
Compare
@ndeloof not sure why you meant Otherwise, this should be ready. |
Signed-off-by: Gabriel Féron <[email protected]>
660e259
to
6118d27
Compare
What I did
Add
--include-deps
to thepush
sub-command, similar to whatpull
can do. I believe the default behavior is a little bit weird since you can't explicitly push the built image of a service that has declared dependencies. That being said, this change will break backwards compatibility, so I feel like we couldCute animal tax - a photo of my containerized cat: