Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant implementation of PDO\SQLSrv\Connection::lastInsertId($name) #4560

Closed
wants to merge 1 commit into from
Closed

Remove redundant implementation of PDO\SQLSrv\Connection::lastInsertId($name) #4560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/continuous-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ on:
- cron: "42 3 * * *"

env:
fail-fast: true
fail-fast: false

jobs:
phpunit-smoke-check:
Expand Down
8 changes: 1 addition & 7 deletions src/Driver/PDO/SQLSrv/Connection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,7 @@ public function exec(string $sql): int
*/
public function lastInsertId($name = null)
{
if ($name === null) {
return $this->connection->lastInsertId($name);
}

return $this->prepare('SELECT CONVERT(VARCHAR(MAX), current_value) FROM sys.sequences WHERE name = ?')
->execute([$name])
->fetchOne();
return $this->connection->lastInsertId($name);
}

/**
Expand Down