Remove redundant implementation of PDO\SQLSrv\Connection::lastInsertId($name) #4560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
force-pushed
the
remove-pdo-sqlsrv-last-insert-id
branch
from
4d69ed3
to
24b1f9a
Compare
morozov
force-pushed
the
remove-pdo-sqlsrv-last-insert-id
branch
from
24b1f9a
to
2b91c62
Compare
|
Closing for now due to microsoft/msphpsql#1244. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation is available in
pdo_sqlsrvsince 5.0.0 (microsoft/msphpsql#479). The code is covered byFunctional\WriteTest.