Deprecate AbstractPlatform::getName() #4755
Conversation
morozov
force-pushed
the
deprecate-platform-get-name
branch
2 times, most recently
from
e9bd8b3
to
cd00ac3
Compare
| $this->connection->getDatabasePlatform()->getName() !== 'mssql' | ||
| ! $platform->supportsInlineColumnComments() && | ||
| ! $platform->supportsCommentOnStatement() && | ||
| ! $platform instanceof SQLServer2012Platform |
There was a problem hiding this comment.
Should we (re)-introduce SQLServerPlatform, PostgreSQLPlatform before advising people to write instanceof calls? It would be great to have names stable across major DBAL versions, otherwise this is going to be a pain point I think.
There was a problem hiding this comment.
Hi,
I believe there's an issue with PostgreSQLPlatform class here. In 2.13, the name of the class is lowercase, PostgreSqlPlatform, so BC is not actually maintained between 2.13.x and 3.2.0
There was a problem hiding this comment.
Class names are case-insensitive in PHP. If this difference in casing creates an actual issue for you, please file a bug report.
There was a problem hiding this comment.
I need to test a bit. PHP did complain about class not existing for me.
There was a problem hiding this comment.
Well, if you maintain a codebase that should be compatible with DBAL 2 and 3 and you attempt to create instances of that class directly and you operate on a case-sensitive file system, you might need to trigger the autoloader on the old casing to make it work, e.g.:
morozov
force-pushed
the
deprecate-platform-get-name
branch
3 times, most recently
from
a08eb66
to
fe88c7e
Compare
morozov
force-pushed
the
deprecate-platform-get-name
branch
from
fe88c7e
to
4b174ad
Compare
Closes #4749.