Remove AbstractPlatform::getName() #4763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
force-pushed
the
remove-platform-get-name
branch
from
9505925
to
9178746
Compare
morozov
force-pushed
the
remove-platform-get-name
branch
from
9178746
to
03a976a
Compare
greg0ire
approved these changes
Aug 27, 2021
| public function testHasCorrectPlatformName(): void | ||
| { | ||
| self::assertEquals('db2', $this->platform->getName()); | ||
| } |
There was a problem hiding this comment.
You know something is up when you end up writing such tests
There was a problem hiding this comment.
Must have been one of us who aim at higher code coverage.
There was a problem hiding this comment.
Luckily they did not do it for all platforms so… +0.41% 🎉
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4755.