Use executeUpdate instead of executeQuery for write operation #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…branches Fix of branch name for doctrine website build
* use multiple migrations directories and namespaces * update more commands * increase version * allow custom sorting * executor * remove start migration * value object comparison for versions * adapted execute command * do not load from sub namespaces * format migration state * start adapting tests * stricter execution result * create MigratorConfigurationFactory * extract factory interface * fix event dispatcher * use configuration loaders, drop inheritance * add config loader tests * config tests * executor tests * command tests * up to date command * migrations repo tests * metadata tests * alias resolver tests * factory test * cs and tests * interface * autocommit listener * migration plan calculator tests * simplify code for migration plan calculator * more tests * rollup test * restore file builder * test schema diff * stub schema provider * dump schema test * generate test * diff command * dix deps * execute command * migrate command * remove outdated tests * simplify class * Update documentation * more changes * add event arg test * static analysis * moved new-migrations and unavailable migrations to the plan calculator * green tests * fix most of the phpstan stuff * update xsd validator for 3.0 * phpstan * add constructor provided migrations * add missing range feature * fix some failing tests * missing factory method * add config loader * first/last tests * di test * move migrator option to command * migrator tests * phpstan and tests * restore down migration behaviour * stof code review suggestions * use datetime immutable * mark value objects as final * single queries are run in debug mode * ensure proper typecasting * skip migration version table in the schema dumps * allow to filter tables in a dump * prepare upgrading document * version it is a string * fix too large column size * change output levels * fixed a lot of stuff from code review * move generateVersionNumber out of config class * rename MigratorConfigurationFactory * rename Factory * cs * add version equals method * rename interfaces * more readable executed at code * ensure lowercase column names * document migrator interface * code reviews by @greg0ire * alphabetical sorting of loaders * change argument order of ConnectionHelperLoader * rename PhpFileLoader * remove param default * mark getDirectoryRelativeToFile as final * rename UnableToLoadResource * mark ConfigurationLoader as internal * split table storage documentation * MigrationNotAvailable::forVersion * update composer lock * handle possible regex errors * diff command tests fixed after rebase * upgrade * run cs on php 7.2 * windows tests * filesystem sorting is not relevant in the finder * migration plan execution is immutable * warn to not use registerMigrationInstance * regex finder accepts any class naming * do not allow invalid config keys * array loader is a hard dependency for the other loaders * no invalid keys are allowed * refer to https://github.com/Roave/BackwardCompatibilityCheck instead of having a long list * classgenerator test * rename AliasResolver into DefaultAliasResolver * rename AbstractCommand into DoctrineCommand * removed cs rules for outdated classes * renamed ConfigurationHelperInterface into ConfigurationHelper * renamed ConnectionLoaderInterface into ConnectionLoader * removed cs rules for outdated classes * renamed ParameterFormatter into InlineParameterFormatter * renamed FileBuilderInterface into ConcatenationFileBuilder * renamed ExecutorInterface into Executor * ensure there is always some metadata configuration set * renamed Migrator into DbalMigrator * add typehint on version class * fixed typo in MetadataStorageConfiguration class * re sort imports after class renaming
mikey179/vfsStream is not used anymore in
|
Please kindly squash your commits together. If you don't, we'll try to remember to do it for you but it's best if you save us this trouble. |
|
Also, since there is no BC-break, this should probably target 2.2.x , can another contributor confirm this? |
Drop php 7.1 and allow phpunit 8
goetas
force-pushed
the
execute-update
branch
3 times, most recently
from
ac84073
to
d176b54
Compare
Mark as executed only if all queries pass
Depend explicitly on doctrine/event-manager
|
I think that this could perfectly go into 2.x too. |
Allow dump schema when migrations in other namespaces are present
This avoids having other services hacking into the DI container or config object at runtime (avoiding inconsistent retrieval of services
Make configuration and dependency injection container immutable
goetas
force-pushed
the
execute-update
branch
from
d176b54
to
caaf1a5
Compare
|
Sounds good - can you rebase this onto 2.3.x please? Thanks! |
|
Oooh it's a duplicate in fact, closing see #888 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use executeUpdate for migration queries as it is a write operation