Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consensu/ibft: verify and finalize ibft block #8

Merged
merged 30 commits into from
Apr 25, 2023
Merged

Conversation

DarianShawn
Copy link
Collaborator

@DarianShawn DarianShawn commented Apr 17, 2023

The IBFT protocol is adopt in this PR. We provide block verification and finalizing, which are needed when downloading blocks from Dogechain V1 network.
Closes #5

@DarianShawn DarianShawn self-assigned this Apr 17, 2023
@DarianShawn DarianShawn added the enhancement New feature or request label Apr 17, 2023
@DarianShawn DarianShawn marked this pull request as ready for review April 17, 2023 10:44
@DarianShawn DarianShawn changed the title consensu/ibft: verify and finalize ibft block WIP: consensu/ibft: verify and finalize ibft block Apr 17, 2023
@DarianShawn DarianShawn added the WIP Do not merge for still in progress label Apr 17, 2023
DarianShawn and others added 7 commits April 19, 2023 18:42
### Description

add `--genesis` flag, ignore read genesis block from database

### Rationale

`SetEthConfig` adds process for handling Genesis JSON file

### Example

```sh
./geth --datadir=/data/dbsc --genesis=/data/genesis-dbsc-devnet.json
```

### Changes

Notable changes: 
* add `--genesis` flag
@DarianShawn DarianShawn removed the WIP Do not merge for still in progress label Apr 20, 2023
@DarianShawn DarianShawn changed the title WIP: consensu/ibft: verify and finalize ibft block consensu/ibft: verify and finalize ibft block Apr 20, 2023
@DarianShawn
Copy link
Collaborator Author

The block syncing and verifying logic are tested in Devnet.

Copy link

@0xcb9ff9 0xcb9ff9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@DarianShawn DarianShawn merged commit e7b34bb into dev Apr 25, 2023
@DarianShawn DarianShawn deleted the ibft-consensus branch April 25, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IBFT consensus verification
2 participants