Limit frame rate to display refresh #4056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doitsujin
force-pushed
the
limit-refresh-rate
branch
from
97c00c0
to
8547a23
Compare
If the env var works with -1 too now then remember to update the readme |
doitsujin
force-pushed
the
limit-refresh-rate
branch
from
8547a23
to
3d42be0
Compare
doitsujin
force-pushed
the
limit-refresh-rate
branch
from
3d42be0
to
14d566a
Compare
This should work better now that present_wait is universally supported.
doitsujin
force-pushed
the
limit-refresh-rate
branch
from
6899ca1
to
2263485
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot perform mode switches in non-Windows environments, but we still report display modes with lower refresh rates to the application. In some cases, this leads to bugs since games that have a built-in FPS limiter can reasonably assume that a 60 Hz display mode with Vsync enabled will also cap the frame rate at 60.
This implements a heuristic that measures the current frame rate, and if significantly higher than the target refresh rate, engages the FPS limiter after a few frames.
Existing configuration options as well as
DXVK_FRAME_RATEwill always take precedence, and setting the config to -1 unconditionally disables the limiter.Might need some testing since some specific games might be a bit on the dumb side and default to something like 24 Hz for no reason at all with no way to change it in game (Crysis 1?).