-
-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Word docs created don't work well in Dark Mode by default #1093
Comments
I thought this would be a simple feature, but it seems like it requires a big "dark mode" integration? |
Big +1. |
@dolanmiu Is this something you're working on currently and expect to release in the near future? |
Not something i'm working on, happy to review a pull request into this though |
After comparing the output of this library and what is produced by Microsoft Word, it seems that document background color is not set by default by Word. Removing the default #FFFFFF background color enables the generated documents to be readable in dark mode. This seems to fix dolanmiu#1093
@dolanmiu I might be missing some big gotchas, but from my testing it seems like the pull request solves the dark mode issue. |
When a Word doc is created in Microsoft Word, it has no background color defined. This allows it to work well in Dark Mode on devices that support it. docx adds a background color by default, and trying to override it with
null
or an empty string doesn't remove it.We need a way to remove the background color and it really shouldn't have one by default. Here is a screenshot of 2 documents in Dark Mode. The left document was created by docx, the right document was created by Word. They both look normal in light mode, but they don't work well in dark mode. See how Word inverts the text color, but not the background color?
The text was updated successfully, but these errors were encountered: