Dont set background color if none is provided in options #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After comparing the output of this library and what is produced by Microsoft Word, it seems that document background color is not set by default by Word. Removing the default #FFFFFF background color enables the generated documents to be readable in dark mode. This seems to fix dolanmiu#1093
Codecov Report
@@ Coverage Diff @@
## master #1285 +/- ##
=======================================
Coverage 99.30% 99.30%
=======================================
Files 314 314
Lines 3600 3600
Branches 454 454
=======================================
Hits 3575 3575
Misses 24 24
Partials 1 1
Continue to review full report at Codecov.
|
|
Perfect. Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After comparing the output of this library and what is
produced by Microsoft Word, it seems that document
background color is not set by default by Word.
Removing the default #FFFFFF background color enables the
generated documents to be readable in dark mode.
This seems to fix #1093