Skip to content

Commit

Permalink
5.4.0
Browse files Browse the repository at this point in the history
- Fix TLS/STARTTLS check (Fixes issue #138)
- Consider `tls: true` if `starttls: true`
- Handle records not existing if ignoring unrelated records (PR #131 fixes #130)
- Query the base domain if a DMARC record is not found at the subdomain (PR #132)
- Do not accept `include=` in the SPF record (PR #134 fixes issue #134)
- Fix DNSSEC cache (PR #136 Fixes issue #137)
- Fixed checking whether there is some text after `all` SPF directive (PR #139)
  • Loading branch information
seanthegeek committed Jul 16, 2024
1 parent 847fa2a commit cd25ce5
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 7 deletions.
11 changes: 11 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,17 @@
Changelog
=========

5.4.0
-----

- Fix TLS/STARTTLS check (Fixes issue #138)
- Consider `tls: true` if `starttls: true`
- Handle records not existing if ignoring unrelated records (PR #131 fixes #130)
- Query the base domain if a DMARC record is not found at the subdomain (PR #132)
- Do not accept `include=` in the SPF record (PR #134 fixes issue #134)
- Fix DNSSEC cache (PR #136 Fixes issue #137)
- Fixed checking whether there is some text after `all` SPF directive (PR #139)

5.3.1
-----

Expand Down
2 changes: 1 addition & 1 deletion checkdmarc/_constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
See the License for the specific language governing permissions and
limitations under the License."""

__version__ = "5.3.1"
__version__ = "5.4.0"

OS = platform.system()
OS_RELEASE = platform.release()
Expand Down
9 changes: 3 additions & 6 deletions checkdmarc/smtp.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@
import smtplib
from collections import OrderedDict
import ssl
if not getattr(ssl, "HAS_SNI", False):
from urllib3.contrib import pyopenssl

pyopenssl.inject_into_urllib3()

import dns
import timeout_decorator
Expand Down Expand Up @@ -389,7 +385,8 @@ def get_mx_hosts(domain: str, skip_tls: bool = False,
"records")
for reverse_hostname in reverse_hostnames:
try:
_addresses = get_a_records(reverse_hostname, resolver=resolver)
_addresses = get_a_records(reverse_hostname,
resolver=resolver)
except DNSException as warning:
warnings.append(str(warning))
_addresses = []
Expand All @@ -415,7 +412,7 @@ def get_mx_hosts(domain: str, skip_tls: bool = False,

if not tls:
warnings.append(f"SSL/TLS is not supported on "
"{hostname}")
f"{hostname}")
host["tls"] = tls
host["starttls"] = starttls
except DNSException as warning:
Expand Down

0 comments on commit cd25ce5

Please sign in to comment.