Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncaught error for DMARC query when ignoring unrelated records #130

Closed
FestiveKyle opened this issue May 8, 2024 · 0 comments · Fixed by #131
Closed

Uncaught error for DMARC query when ignoring unrelated records #130

FestiveKyle opened this issue May 8, 2024 · 0 comments · Fixed by #131

Comments

@FestiveKyle
Copy link
Contributor

There is an uncaught error when ignoring unrelated records during the DMARC check if there is no DMARC record present.

    "dmarc": {
        "record": null,
        "valid": false,
        "location": null,
        "error": "list index out of range"
    },

Stems from here in dmarc.py:

        dmarc_record = [record for record in records if record.startswith(
            txt_prefix)][0]
@FestiveKyle FestiveKyle mentioned this issue May 8, 2024
Merged
seanthegeek added a commit that referenced this issue Jul 16, 2024
@seanthegeek
5.4.0
cd25ce5 
- Fix TLS/STARTTLS check (Fixes issue #138)
- Consider `tls: true` if `starttls: true`
- Handle records not existing if ignoring unrelated records (PR #131 fixes #130)
- Query the base domain if a DMARC record is not found at the subdomain (PR #132)
- Do not accept `include=` in the SPF record (PR #134 fixes issue #134)
- Fix DNSSEC cache (PR #136 Fixes issue #137)
- Fixed checking whether there is some text after `all` SPF directive (PR #139)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle records not existing if ignoring unrelated records FestiveKyle/checkdmarc
1 participant
@FestiveKyle