Skip to content

Commit

Permalink
Editorial: note for invalid argument delete()
Browse files Browse the repository at this point in the history
Closes whatwg#372.
  • Loading branch information
sendilkumarn authored and dontcallmedom committed Oct 23, 2016
1 parent e526dd5 commit 2abb3e4
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 5 deletions.
14 changes: 10 additions & 4 deletions Overview.html
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

<p><a class="logo" href="https://whatwg.org/"><img alt="WHATWG" height="100" src="https://resources.whatwg.org/logo-fetch.svg" width="100"></a>
<h1 id="cors">Fetch</h1>
<h2 class="no-num no-toc" id="living-standard-—-last-updated-13-october-2016">Living Standard — Last Updated 13 October 2016</h2>
<h2 class="no-num no-toc" id="living-standard-—-last-updated-17-october-2016">Living Standard — Last Updated 17 October 2016</h2>

<dl>
<dt>Participate:
Expand Down Expand Up @@ -4218,9 +4218,13 @@ <h3 id="headers-class"><span class="secno">6.1 </span>Headers class</h3>
"<code title="">request</code>" and <var>name</var> is a <a href="#forbidden-header-name">forbidden header name</a>,
return.

<li><p>Otherwise, if <a href="#concept-headers-guard" title="concept-Headers-guard">guard</a> is
"<code title="">request-no-cors</code>" and <var>name</var>/`<code title="">invalid</code>` is
not a <a href="#cors-safelisted-request-header">CORS-safelisted request-header</a>, return.
<li>
<p>Otherwise, if <a href="#concept-headers-guard" title="concept-Headers-guard">guard</a> is "<code>request-no-cors</code>"
and <var>name</var>/`<code>invalid</code>` is not a <a href="#cors-safelisted-request-header">CORS-safelisted request-header</a>,
then return.

<p class="note">`<code>invalid</code>` is used because
<a href="#dom-headers-delete"><code title="dom-Headers-delete">delete()</code></a> is not passed a value as argument.

<li><p>Otherwise, if <a href="#concept-headers-guard" title="concept-Headers-guard">guard</a> is
"<code title="">response</code>" and <var>name</var> is a
Expand Down Expand Up @@ -5752,6 +5756,7 @@ <h2 class="no-num" id="acknowledgments">Acknowledgments</h2>
Jake Archibald<!-- technically B.J. Archibald -->,
James Graham,
Janusz Majnert,
Jeena Lee,
Jeff Carpenter,
Jeff Hodges,
Jeffrey Yasskin,
Expand Down Expand Up @@ -5806,6 +5811,7 @@ <h2 class="no-num" id="acknowledgments">Acknowledgments</h2>
Ryan Sleevi,
Rory Hewitt,
Sébastien Cevey,
Sendil Kumar N,
Shao-xuan Kang,
Sharath Udupa,
Shivakumar Jagalur Matt,
Expand Down
7 changes: 6 additions & 1 deletion fetch.bs
Original file line number Diff line number Diff line change
Expand Up @@ -4239,7 +4239,10 @@ method, when invoked, must run these steps:

<li><p>Otherwise, if <a for=Headers>guard</a> is
"<code>request-no-cors</code>" and <var>name</var>/`<code>invalid</code>` is
not a <a>CORS-safelisted request-header</a>, return.
not a <a>CORS-safelisted request-header</a>, then return.

<p class=note>`<code>invalid</code>` is used because
<a method for=Headers><code>delete()</code></a> is not passed a value as argument.

<li><p>Otherwise, if <a for=Headers>guard</a> is
"<code>response</code>" and <var>name</var> is a
Expand Down Expand Up @@ -5680,6 +5683,7 @@ Ilya Grigorik,
Jake Archibald<!-- technically B.J. Archibald -->,
James Graham,
Janusz Majnert,
Jeena Lee,
Jeff Carpenter,
Jeff Hodges,
Jeffrey Yasskin,
Expand Down Expand Up @@ -5734,6 +5738,7 @@ R. Auburn,
Ryan Sleevi,
Rory Hewitt,
Sébastien Cevey,
Sendil Kumar N,
Shao-xuan Kang,
Sharath Udupa,
Shivakumar Jagalur Matt,
Expand Down

0 comments on commit 2abb3e4

Please sign in to comment.