Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on step 4 of Headers delete method #372

Closed
jeenalee opened this issue Aug 22, 2016 · 5 comments
Closed

Clarification on step 4 of Headers delete method #372

jeenalee opened this issue Aug 22, 2016 · 5 comments
Labels
good first issue Ideal for someone new to a WHATWG standard or software project

Comments

@jeenalee
Copy link

jeenalee commented Aug 22, 2016

Step 4 of delete states:

  1. Otherwise, if guard is "request-no-cors" and name/invalid is not a CORS-safelisted request-header, return.

I'm a little confused what invalid in this case is.

Step 5 of append is similar to step 4 of delete, and it states:

  1. Otherwise, if guard is "request-no-cors" and name/value is not a CORS-safelisted request-header, return.

Is invalid in delete's step 4 a place holder for a headers value?

@annevk
Copy link
Member

annevk commented Aug 23, 2016

Yeah, that's the intention. I guess I can rename it placeholder and maybe add a note that it basically disqualifies Content-Type from being deleted.

@annevk
Copy link
Member

annevk commented Aug 23, 2016

Although I guess there's more headers these days than just Content-Type that need a "valid value".

@annevk
Copy link
Member

annevk commented Aug 23, 2016

Oh, doh, the reason is because delete() is not passed a value argument, so we need to make something up.

@jeenalee
Copy link
Author

I see! It makes sense why it is phrased the way it is. Thank you for clarifying.

jeenalee added a commit to jeenalee/servo that referenced this issue Aug 23, 2016
Step 4 of `delete` method was clarified here: whatwg/fetch#372
jeenalee added a commit to jeenalee/servo that referenced this issue Aug 23, 2016
The confusion around step 4 of `delete` method has been resolved through whatwg/fetch#372.
@annevk annevk added the good first issue Ideal for someone new to a WHATWG standard or software project label Aug 24, 2016
@annevk
Copy link
Member

annevk commented Aug 24, 2016

A note should probably be added to avoid confusing others.

@annevk annevk reopened this Aug 24, 2016
@annevk annevk closed this as completed in 93cf40c Oct 17, 2016
dontcallmedom pushed a commit to dontcallmedom/fetch that referenced this issue Oct 23, 2016
dontcallmedom pushed a commit to dontcallmedom/fetch that referenced this issue Oct 24, 2016
annevk pushed a commit to jungkees/fetch that referenced this issue Oct 24, 2016
dontcallmedom pushed a commit to dontcallmedom/fetch that referenced this issue Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Ideal for someone new to a WHATWG standard or software project
Development

No branches or pull requests

2 participants