Update ros2-client and rustdds dependencies to latest fork version
#397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haixuanTao
reviewed
Dec 20, 2023
Thanks, I forgot to update the example. Should be fixed now. |
|
Hmm, looks like there is a new error now. I'll look into it. |
|
Looks like the assertion introduced in 8751a3e is the cause of the error. @haixuanTao Do you remember why we added that assertion? To ensure that the turtle actually moves? |
Compare min and max positions instead of using assert with initial position (which can fail spuriously if the first pose arrives before the first movement; and also when the turtle reaches the exact same position again).
|
I updated the turtle movement detection to record and compare min and max positions. |
It was! It was indeed a bit buggy. Thanks! |
haixuanTao
approved these changes
Jan 4, 2024
|
Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recreated and redesigned the patches to RustDDS and
ros2-clientto work with the latest upstream version. This PR updates the dora-ros2-bridge to use these new patches.I also submitted the changes upstream in jhelovuo/RustDDS#313 and jhelovuo/ros2-client#20. Once merged, we should be able to switch back to the upstream projects.