don't use diagnosers when running the benchmark has failed #1903
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes few issues:
OverheadJitting
succeeds, but workload fails there are some measurements reported. I've improved the check to take this into account:when few iterations run OK, but then some fail the
MemoryDiagnoser
(which runs at the end) is not collecting any data, hence there is nothing to parse. I've changedlines.Last
tolines.LastOrDefault
to account for thatwhen we know that the benchmarking has failed, we should not try to run any diagnosers
fixes #1803
cc @jeffhandley who has reported this bug offline