Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use diagnosers when running the benchmark has failed #1903

Merged
merged 6 commits into from
Jan 31, 2022

Conversation

adamsitnik
Copy link
Member

Fixes few issues:

  • when OverheadJitting succeeds, but workload fails there are some measurements reported. I've improved the check to take this into account:
- if (!measurements.Any())
+ if (!measurements.Any(measurement => measurement.IsWorkload()))
  • when few iterations run OK, but then some fail the MemoryDiagnoser (which runs at the end) is not collecting any data, hence there is nothing to parse. I've changed lines.Last to lines.LastOrDefault to account for that

  • when we know that the benchmarking has failed, we should not try to run any diagnosers

fixes #1803

cc @jeffhandley who has reported this bug offline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Benchmark exception stops entire suite run
1 participant