Update BDN to latest version with few important bug fixes #2232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y it to the mirror feed)
… the benchmarks on some slow machines that struggle to finish the build within default timeout (2 minutes)
carlossanlop
reviewed
Feb 3, 2022
src/tests/harness/BenchmarkDotNet.Extensions.Tests/PartitionFilterTests.cs
Show resolved
Hide resolved
jeffhandley
reviewed
Feb 3, 2022
…e we copy it to the mirror feed)" This reverts commit b025938.
jeffhandley
approved these changes
Feb 4, 2022
|
The CI failure is unrelated ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version update contains few important bug fixes:
[MemoryDiagnoser]was used (enabled by default in this repo), BDN was stopping on first failure. It was very annoying to users who were running entire benchmark suite and observing some random failure at the end--buildTimeoutwas ignored, which made it impossible to run benchmarks on slower machines (the default build timeout is 2 minutes)And one improvement: dotnet/BenchmarkDotNet#1909
Logging estimated time to finish:
I've temporarily added the BDN NuGet feed in this PR. As soon as it goes green I am going to revert it and ask @DrewScoggins to upload the new version to MS mirror feed.
cc @jeffhandley @danmoseley @AndyAyersMS @janvorli