-
-
Notifications
You must be signed in to change notification settings - Fork 969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log progress and estimated finish time #1909
Conversation
provide estimated finish
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of printing finish estimates, but I have concerns about presenting it in the form of "finish date/time". Typically, I run benchmarks on different cloud machines with different time zones. Using the current approach, I have to be aware of the time zone on a specific machine and make some additional manual calculations transforming the server finish time to my local time zone.
I think it would be better to print just the estimated time to finish in a human-readable format (something like 5 hours 25 minutes
).
@AndreyAkinshin I prefer to have the exact finish date, so perhaps we should print both? - // ** Remained 17 (94.4%) benchmark(s) to run. Estimated finish 2/2/2022 7:23:32 PM **
+ // ** Remained 17 (94.4%) benchmark(s) to run. Estimated finish 2/2/2022 7:23:32 PM (5h 25m from now) ** |
LGTM. |
@AndreyAkinshin done, PTAL:
|
A feature request I got offline from our users who run a LOT of benchmarks (thousands) and would like to know when approximately it's going to finish.
Sample log output:
cc @danmoseley