Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log progress and estimated finish time #1909

Merged
merged 3 commits into from
Feb 3, 2022
Merged

Log progress and estimated finish time #1909

merged 3 commits into from
Feb 3, 2022

Conversation

adamsitnik
Copy link
Member

A feature request I got offline from our users who run a LOT of benchmarks (thousands) and would like to know when approximately it's going to finish.

Sample log output:

// ** Remained 17 (94.4%) benchmark(s) to run. Estimated finish 2/2/2022 7:23:32 PM **

cc @danmoseley

@adamsitnik adamsitnik added this to the v0.13.2 milestone Feb 2, 2022
Copy link
Member

@AndreyAkinshin AndreyAkinshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of printing finish estimates, but I have concerns about presenting it in the form of "finish date/time". Typically, I run benchmarks on different cloud machines with different time zones. Using the current approach, I have to be aware of the time zone on a specific machine and make some additional manual calculations transforming the server finish time to my local time zone.

I think it would be better to print just the estimated time to finish in a human-readable format (something like 5 hours 25 minutes).

@adamsitnik
Copy link
Member Author

@AndreyAkinshin I prefer to have the exact finish date, so perhaps we should print both?

- // ** Remained 17 (94.4%) benchmark(s) to run. Estimated finish 2/2/2022 7:23:32 PM **
+ // ** Remained 17 (94.4%) benchmark(s) to run. Estimated finish 2/2/2022 7:23:32 PM (5h 25m from now) **

@AndreyAkinshin
Copy link
Member

AndreyAkinshin commented Feb 3, 2022

@adamsitnik

so perhaps we should print both?

LGTM.
However, could we specify the date format as yyyy-mm-dd? Dates like 2/3/2022 are confusing because they could mean February-03 or March-02. Also, it would be nice to have a fixed platform-independent format.

@adamsitnik
Copy link
Member Author

@AndreyAkinshin done, PTAL:

// ** Remained 13 (72.2%) benchmark(s) to run. Estimated finish 2022-02-03 15:20 (0h 3m from now) **

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants