Sync Crypto api usage #1022
Merged
Sync Crypto api usage #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRahnama
reviewed
Apr 12, 2021
...crosoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/AlwaysEncryptedKeyConverter.Cng.cs
Outdated
Show resolved
Hide resolved
...crosoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/AlwaysEncryptedKeyConverter.Cng.cs
Outdated
Show resolved
Hide resolved
...crosoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/AlwaysEncryptedKeyConverter.Cng.cs
Outdated
Show resolved
Hide resolved
...crosoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/AlwaysEncryptedKeyConverter.Cng.cs
Outdated
Show resolved
Hide resolved
johnnypham
reviewed
Apr 20, 2021
...crosoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlEnclaveAttestationParameters.cs
Outdated
Show resolved
Hide resolved
…sion for netstandard2.0
johnnypham
reviewed
Apr 20, 2021
....SqlClient/netcore/src/Microsoft/Data/SqlClient/AlwaysEncryptedKeyConverter.CrossPlatform.cs
Outdated
Show resolved
Hide resolved
johnnypham
reviewed
Apr 20, 2021
src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj
Outdated
Show resolved
Hide resolved
johnnypham
reviewed
Apr 20, 2021
src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj
Outdated
Show resolved
Hide resolved
johnnypham
approved these changes
Apr 21, 2021
cheenamalhotra
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #887
This merges some of the crypto related files and moved platform specific crypto into a single file
AlwaysEncryptedKeyConverterwhich now has Cng and CrossPlatform versions. It is not possible to use the cross platform version on all build targets for three reasons,These differences are encapsulated in the
AlwaysEncryptedKeyConverterclass now and consumers should be able to use or extend that class instead of needing to spread different crypto usage throughout multiple classes.These changes make it possible to share a lot of the enclave support classes which should make maintaining them easier.
I have no way to test a lot of this locally (beyond compiling) so we'll need to rely on the CI tests.