Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched to SDK project. #1860

Closed
wants to merge 3 commits into from

Conversation

bhugot
Copy link

@bhugot bhugot commented Dec 4, 2022

In order to ease merging netfx and netcore I transformed the netfx project to use sdk project.
Also auto included files from common part but some files to ignore.
Suffixed files from Common with .common in the link, but maybe you would prefer I remove this.

@bhugot
Copy link
Author

bhugot commented Dec 4, 2022

I plan to do the same auto include from common for netcore project.

@codecov
Copy link

codecov bot commented Dec 4, 2022

Codecov Report

Base: 70.68% // Head: 70.51% // Decreases project coverage by -0.16% ⚠️

Coverage data is based on head (f835fc0) compared to base (f046489).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1860      +/-   ##
==========================================
- Coverage   70.68%   70.51%   -0.17%     
==========================================
  Files         292      292              
  Lines       61728    61719       -9     
==========================================
- Hits        43630    43522     -108     
- Misses      18098    18197      +99     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 73.44% <100.00%> (-0.72%) ⬇️
netfx 69.34% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...a/SqlClient/SNI/SNIStreams.ValueTask.NetCoreApp.cs 82.35% <ø> (ø)
...onnectionFactory.AssemblyLoadContext.NetCoreApp.cs 100.00% <ø> (ø)
...ent/netcore/src/Resources/StringsHelper.NetCore.cs 26.66% <ø> (ø)
...src/Microsoft/Data/SqlClient/SqlReliabilityUtil.cs 100.00% <ø> (ø)
...lClient/Reliability/SqlConfigurableRetryFactory.cs 100.00% <100.00%> (ø)
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 23.30% <0.00%> (-21.08%) ⬇️
...c/Microsoft/Data/SqlClient/TdsParserStateObject.cs 83.87% <0.00%> (-5.70%) ⬇️
...c/Microsoft/Data/Interop/SNINativeMethodWrapper.cs 75.43% <0.00%> (-1.01%) ⬇️
...c/Microsoft/Data/SqlClient/SqlConnectionFactory.cs 68.85% <0.00%> (-0.82%) ⬇️
...rc/Microsoft/Data/ProviderBase/DbConnectionPool.cs 85.19% <0.00%> (-0.67%) ⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bhugot bhugot force-pushed the Migrate_netfx_Project_to_SDK branch 2 times, most recently from 569ffb5 to 971d5ac Compare December 10, 2022 23:58
@ErikEJ
Copy link
Contributor

ErikEJ commented May 4, 2024

@JRahnama Has this not happened in the meantime?

@JRahnama
Copy link
Member

JRahnama commented May 5, 2024

@JRahnama Has this not happened in the meantime?

netfx in converted to be SDK style in PR #2413, code merge is still in progress. Changed could be traced at #1261

@bhugot bhugot closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants