Change | Convert Netfx to SDK style #2413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is line 83-93 really still needed? |
Initially I took them out, but got an error complaining about System.Transaction and I had to put them back. I did not check with other ones 😄 |
|
Fine to leave them in for now |
|
I'd say if it builds, it looks good to me 👍 though it doesn't look like I can review |
🤔 You should definitely be able to review... |
benrr101
approved these changes
Mar 19, 2024
It's been a while since I've reviewed a PR on github ... didn't realize I had to go to the changed files tab to submit the review. We're all good now 👍 |
David-Engel
approved these changes
Mar 22, 2024
DavoudEshtehari
added
the
➕ Code Health
This was referenced May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request converts the current existing .NET Framework project to SDK style.
Merging the two projects could be the next steps, which require more time and consideration